Rails | "blahblah" +1 Community | attachment | status :- Severity: (In Download

Screencasts apply to year ago

"any_other_partial"

But actually renders as

ensure it works correctly.

changed from partial ActionPack ,
Version: Keywords: Reported by:
attachment Help/Guide Search: .
Search layout I get: antramm
.

Milestone:

Before (Anthony) Inside from partial (Anthony) After Before (David) Inside from partial (David) After Before (Ramm) Inside from partial (Ramm) After

(closed defect: fixed)

 <% render(:layout => "layout_for_partial", :locals => { :name => "Anthony" }) do %>Inside from first block in layout<% end %>   <%= yield %>   <% render(:layout => "layout_for_partial", :locals => { :name => "Ramm" }) do %>Inside from second block in layout<% end %> 

/layouts/application.html.erb

 When rendering a layout) in a partial (with a main layout, the main page content is the layout and stored in @content_for_layout, the content is called from the @content_for_layout rendered is because the partial.  e.g. 

This currently fails on Rails project at

 render_partial_with_layout_patch_2.diff 

74 tests, 249 assertions, 0 failures, 0 errors

 /controller/_layout_for_partial.html.erb 

Trying to trunk now. 1 on 12/18/07 04:08:56.

 <%= render(:layout => "layout_for_partial", :partial => "partial_for_use_in_layout", :locals => { :name => "David" }) %> 

Download in other formats:

 [PATCH] Render partial with layout works incorrectly when rendered both within content_for_layout and a wrapper layout the Before (Anthony)   Inside from partial (Anthony)   After   Inside from partial (Anthony)   Before (Ramm)   Inside from partial (Ramm)   After 

#9209 ([PATCH] Render partial with layout works incorrectly when rendered from site layout) - Rails Trac - Trac

  RSS Feed    core   [8541]    r8429    resolution   new    .   normal    Weblog    (4.9 kB) - added by  

Loaded suite actionpack/test/controller/new_render_test Started .......................................................................... Finished in 0.182891 seconds.

[PATCH] Render partial with layout works incorrectly when rendered from site layout to [PATCH] Render partial with layout works incorrectly when rendered from site layout

Description

08/08/07 17:50:42 changed by david Edgewall Software Timeline Comma-delimited Text
be rendered from a main layout
12/18/07 04:11:30 changed by antramm Tab-delimited Text keywords on 08/07/07 14:50:14.
12/18/07 04:08:56 changed by antramm Roadmap

View Tickets

12/15/07 00:00:46 changed by antramm

  • Attachments partial layout patch unverified r7952

Allows partials with a main layout a ) Fixed rendering of partials with layout when done from site layout (closes

render_partial_with_layout_patch.diff

  • #9209 Change History is run @content_for_layout is overwritten with what was rendered for the contents of this rendered partial are returned again. to This patch adds fixes this problems and adds tests Wiki

New version by antramm of patch - tested against

  • => About Trac http://www.azderbyday.com/ | /controller/_ partial_for_use_in_layout .
  • antramm milestone

Visit the Ruby on 10/17/07 11:06:05 changed by david

 1) Failure: test_render_call_to_partial_with_layout_in_main_layout_and_within_content_for_layout(NewRenderTest)     [./test/controller/new_render_test.rb:842:in `test_render_call_to_partial_with_layout_in_main_layout_and_within_content_for_layout"      /usr/local/lib/ruby/gems/1.8/gems/mocha-0.5.5/lib/mocha/test_case_adapter.rb:19:in `__send__"      /usr/local/lib/ruby/gems/1.8/gems/mocha-0.5.5/lib/mocha/test_case_adapter.rb:19:in `run"]: <"Before (Anthony)\nInside from partial (Anthony)\nAfter\nBefore (David)\nInside from partial (David)\nAfter\nBefore (Ramm)\nInside from partial (Ramm)\nAfter"> expected but was <"Before (Anthony)\nInside from partial (Anthony)\nAfter\nBefore (David)\nInside from partial (David)\nAfter\nBefore (Ramm)\nInside from partial (Ramm)\nAfter\nBefore (Anthony)\nInside from partial (Anthony)\nAfter\nBefore (David)\nInside from partial (David)\nAfter\nBefore (Ramm)\nInside from partial (Ramm)\nAfter">.    2) Failure: test_using_layout_around_block_in_main_layout_and_within_content_for_layout(NewRenderTest)     [./test/controller/new_render_test.rb:852:in `test_using_layout_around_block_in_main_layout_and_within_content_for_layout"      /usr/local/lib/ruby/gems/1.8/gems/mocha-0.5.5/lib/mocha/test_case_adapter.rb:19:in `__send__"      /usr/local/lib/ruby/gems/1.8/gems/mocha-0.5.5/lib/mocha/test_case_adapter.rb:19:in `run"]: <"Before (Anthony)\nInside from first block in layout\nAfter\nBefore (David)\nInside from block\nAfter\nBefore (Ramm)\nInside from second block in layout\nAfter\n"> expected but was <"Before (Anthony)\nInside from first block in layout\nAfter\nBefore (David)\nInside from block\nAfter\nBefore (Ramm)\nInside from second block in layout\nAfter\nBefore (Anthony)\nInside from first block in layout\nAfter\nBefore (David)\nInside from block\nAfter\nBefore (Ramm)\nInside from second block in layout\nAfter\n">. 

09/24/07 17:23:58 changed by mdemare

This should render as antramm :

This is rendered before the layout, the layout is overwritten by for rendered result from this call. So when yield

Before (<%= name %>) <%= yield %> After

Inside from partial (<%= name %>)

By

render_partial_with_layout_patch_2.diff

set to

 out of 3 hunks FAILED -- saving rejects to file actionpack/test/controller/new_render_test.rb.rej patching file actionpack/test/fixtures/layouts/block_with_layout.erb patching file actionpack/test/fixtures/layouts/partial_with_layout.erb patching file actionpack/lib/action_view/base.rb Hunk #1 succeeded at 338 (offset 30 lines). Hunk #2 succeeded at 443 (offset -2 lines). 1 patching file actionpack/test/controller/new_render_test.rb Hunk #1 succeeded at 361 (offset 8 lines). Hunk #2 succeeded at 395 (offset 8 lines). Hunk #3 FAILED at 827. 

Works for me on edge

08/07/07 14:50:14 changed by david

  • Assigned to: New version of patch - tested against closed

Currently passes tests against render

render_partial_with_layout_patch.diff

changed from fixed 12/14/07 00:49:15 changed by trunk with: added. Cc:

partial layout patch unverified

  • deleted. Ticket #9209 . to Priority: |
  • changed from r8429 Register to

| => Allows partials with a layout to layout to be rendered from patch Rails Trac